Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextServer::shaped_text_*_character_pos for the first character of wrapped string. Allow starting/ending RTL selection before line start. #95301

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 8, 2024

… of wrapped string. Allow starting/ending RTL selection before line start.
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 9, 2024
@eviltrout
Copy link
Contributor

I tested this change locally and can confirm it completely solves the issues. I tested with indents and without, with content margins too. Works great. Thank you so much @bruvzg!

@kitbdev
Copy link
Contributor

kitbdev commented Aug 10, 2024

@akien-mga akien-mga merged commit aed6c35 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select the first letter of a wrapped line in a RichTextLabel
4 participants