-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ExportPlugin
to add export messages; use in C# export plugin
#90555
Conversation
I've been planning to eventually make a PR to add an This would be helpful in allowing folks to add support for exporting to console, for example, without needing to make a custom build of the editor. In any case, as part of that work, we'd need to expose |
Allow export plugins to add messages to the preset's export platform.
Integrates .NET error messages with the export log dialog.
That's a good point, the alternative design would also supersede #90556 since having access to the That said, as long as |
75480a6
to
c69851b
Compare
Ah, yeah, that makes sense. Having |
I'll make a PR for the C# changes in this PR after #90782 is merged. |
EditorExportPlatform::add_message
as a method inExportPlugin
so plugins can add messages that will be displayed in the export log at the end of exporting.ExportPlugin::add_message
in the C# export plugin to add error messages instead of a custom error dialog. Integrates the .NET error messages with the export log dialog so only one dialog is displayed.Alternative design
We could alternatively expose the method in
EditorExportPlatform
and add aget_export_platform
method toExportPlugin
so we could retrieve the export platform from the plugin.