-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding custom export platforms using scripts / GDExtension. #90782
Allow adding custom export platforms using scripts / GDExtension. #90782
Conversation
03efc5e
to
b454652
Compare
Thanks for taking this on! I started a local branch with the same goal back in January, but just haven't had the time to finish it up. Your version is already further along than mine :-) |
d39b196
to
252a630
Compare
This comment was marked as outdated.
This comment was marked as outdated.
252a630
to
10fb9c0
Compare
895e9b7
to
754dc47
Compare
754dc47
to
20f5bd9
Compare
20f5bd9
to
36c16f1
Compare
9b4b8a6
to
861ed71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have yet to test it but the logic looks good.
861ed71
to
22375d4
Compare
I tested this with the C# ExportPlugin to implement the C# changes from my superseded PRs (raulsntos@c069790) and works great. I don't understand the changes to expose Also, since diff --git a/editor/export/editor_export_platform.cpp b/editor/export/editor_export_platform.cpp
index eb9e9b9adf..53d6d689a1 100644
--- a/editor/export/editor_export_platform.cpp
+++ b/editor/export/editor_export_platform.cpp
@@ -71,7 +71,7 @@ bool EditorExportPlatform::fill_log_messages(RichTextLabel *p_log, Error p_err)
p_log->add_text(" ");
p_log->add_text(get_name());
p_log->add_text(" - ");
- if (p_err == OK) {
+ if (p_err == OK && get_worst_message_type() < EditorExportPlatform::EXPORT_MESSAGE_ERROR) {
if (get_worst_message_type() >= EditorExportPlatform::EXPORT_MESSAGE_WARNING) {
p_log->add_image(p_log->get_editor_theme_icon(SNAME("StatusWarning")), 16 * EDSCALE, 16 * EDSCALE, Color(1.0, 1.0, 1.0), INLINE_ALIGNMENT_CENTER);
p_log->add_text(" ");
Otherwise, an |
22375d4
to
aadc8e9
Compare
Added it.
It might be necessary if you want to implement custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your epic work on this! It's looking really great :-)
I haven't tested it, but all the important code looks good to me - I just have two little notes.
fe06d18
to
4a80b01
Compare
Looks like this one needs a rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
4a80b01
to
07e986f
Compare
Thanks! |
@bruvzg where can I read the documentation about this? |
Apart from editor embedded docs for |
Adds option to make custom export platforms using scripts or GDExtension without editor rebuild.
TODO:
EditorExportPlatform
(zip / pck creation, finding export template, ssh/scp methods).ExportPreset
properties.