Optimize get_path()
in EditorFileSystemDirectory
#93611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorFileSystemDirectory's
get_path()
works by traversing its parent directories and concatenating strings. It's horribly inefficient, but seems to be called a lot during scans.I optimized it using PackedStringArray (the path is built in reverse order, so couldn't really use StringBuilder) and the optimized version seems to be ~150% faster. This of course depends on nesting level, I tested with 6 levels of nesting.
Alternative is adding a cached path String to each EditorFileSystemDirectory, which would be even faster, but use more memory.