Fix AnimationPlayer crash when it's made the scene root
#94945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
AnimationPlayer crashing godot when it's made the scene root
AThousandShips
added
bug
crash
topic:animation
cherrypick:4.2
TokageItLab
reviewed
Aug 26, 2024
|
As I wrote in #91043 (comment), I can't actually reproduce the crash of issue #91043. Can you raise a video or something that reproduces the occurrence of the crash? As the this PR change is understandable, so for approving, we need to actually see the crash reproduced and if this PR fix it. |
TokageItLab
approved these changes
Sep 2, 2024
akien-mga
changed the title
AnimationPlayer crashing godot when it's made the scene rootAnimationPlayer crashing when it's made the scene root
akien-mga
changed the title
AnimationPlayer crashing when it's made the scene rootAnimationPlayer crash when it's made the scene root
When an AnimationPlayer is made root of a scene, the track links may become broken and clicking on them will crash. Current master branch also breaks node links when AnimationPlayer is made scene root, and can also crash the engine if another node was made scene root prior to the AnimationPlayer. This happens because when made root, the editor loses track of AnimPlayer's root node. By keeping a copy of the AnimPlayer's root_node, the track links remain functional. Fixes godotengine#91043.
akien-mga
force-pushed
the
fix-anim-player-root-crash
branch
from
0e53572 to
e905be8
Compare
|
I updated the PR branch to squash the commits and tweaked the commit message a bit. Should be ready to merge once CI passes. |
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AnimationPlayer node is made the root of a scene, the node links on the Animation Track can become broken and clicking on them will crash Godot 4.2.2-stable. The current master branch also breaks the node links when AnimationPlayer is made scene root, and can also crash the engine if another node was made the scene root prior to the AnimationPlayer (See Issue #91043)
This happens because when made root, the editor loses track of AnimationPlayer's
root_node. By keeping a cached pointer to theroot_node, the track links can remain functional.Fixes Crash in 4.2.2-stable and Fixes Broken Node Links and Potential Crash in current master branch.