Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha material's reverse cull order. #96431

Merged

Conversation

viksl
Copy link
Contributor

@viksl viksl commented Sep 1, 2024

Fixes alpha materials being rendered with a reverse cull which is visible in reflections from reflection probes.

It seems the reverse_cull variable was used to fix the opaque pass but forgotten for the alpha pass.

Before:
Screenshot 2024-09-01 015956
Screenshot 2024-09-01 000451

After:
Screenshot 2024-09-01 020136

EDIT:
Fixes #96429 .

@viksl viksl requested a review from a team as a code owner September 1, 2024 10:13
@clayjohn clayjohn added this to the 4.4 milestone Sep 1, 2024
@clayjohn clayjohn added bug topic:rendering cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 1, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit f546bf6 into godotengine:master Sep 2, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@viksl viksl deleted the fix-alpha-reflections-cull-order branch September 2, 2024 10:33
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transparent (alpha) reflections from ReflectionProbe are rendered in a reverse cull order.
3 participants