Fix editor layout reset on startup #96581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure it's a regression from #93064. While loading the docks,
EditorDockManager::_update_layout
callsEditorNode::get_singleton()->save_editor_layout_delayed()
before the editor finishes loading the last editor layout. This starts a timer to save the layout after 0.5 seconds. With the addition of a progress dialog inEditorNode::_load_editor_layout
, the timer started insave_editor_layout_delayed
can now be executed before the editor finishes loading, as the signal can be processed duringMain::Iteration
.I added a new global boolean
load_editor_layout_done
to prevent the editor layout from being saved before it is fully loaded.