-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FileSystem Dock] Add option to show some unsupported files in the dock. #96603
Conversation
As far as I understand, absolutely any files will be shown? |
Any file with an extension specified in the setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Linux, it works as expected.
Folder colors are correctly preserved across restarts. Folders and files can be renamed within the FileSystem dock, even if they are within a symbolic link that points outside the project folder (as expected).
Note that Godot is unable to rename symbolic link folders themselves from the FileSystem dock (here, res://symlink_target/
points to /tmp/symlink_target/
which I have write access to):
Perhaps this could be handled, or at least specifically detected so that a dedicated error message is shown. Renaming symbolic link files works though.
There's still the question of whether we should have a temporary toggle to display all files in the project folder, regardless of the editor setting that determines which file extensions are shown.
PS: In a future PR, we should see if symlinks can have their text be displayed in italic to mimic how KDE's Dolphin displays them.
We have For the reference, macOS Finder mark symlinks with the arrow in the corner, and I think Windows do the same, so it might be better option than italic:
There's "Show in file manager" option which should be sufficient for the quick access to all files, and permanently showing all files is unlikely useful. |
Thanks! |
Adds editor setting to specify unsupported file extensions to show in the docs, files are opened using
OS::shell_open
.Closes godotengine/godot-proposals#10662
Closes godotengine/godot-proposals#677