Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clear button on Array[Node]. #96620

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix clear button on Array[Node]. #96620

merged 1 commit into from
Sep 9, 2024

Conversation

ajreckof
Copy link
Member

@ajreckof ajreckof commented Sep 5, 2024

Fix #96273

@fire fire changed the title fix clear button on Array[Node]. Fix clear button on Array[Node]. Sep 5, 2024
@kleonc kleonc added bug topic:gdscript topic:editor cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 5, 2024
@kleonc kleonc added this to the 4.4 milestone Sep 5, 2024
kleonc
kleonc reviewed Sep 5, 2024
View reviewed changes
@ajreckof ajreckof force-pushed the fix-clear-button-on-Array-Node] branch from be11ef2 to dee0453 Compare September 6, 2024 11:40
kleonc
kleonc approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue.

dalexeev
dalexeev approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@akien-mga akien-mga merged commit a0823ce into godotengine:master Sep 9, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleonc kleonc kleonc approved these changes

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Exported Vars: Cannot clear item from array when hint is Array[Node]
4 participants
@ajreckof @akien-mga @kleonc @dalexeev