Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR: Allow extending Android surface swapchain creation from GDExtension #97252

Merged

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Sep 20, 2024

This builds on top of PR #96185 which added the ability to have OpenXRCompositionLayers that display content from Android surfaces.

This PR allows GDExtensions to extend the creation of the Android swapchain via OpenXR extensions.

I'm using this to implement support for XR_FB_android_surface_swapchain_create in 'godot_openxr_vendors' in PR GodotVR/godot_openxr_vendors#208

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@m4gr3d m4gr3d modified the milestones: 4.x, 4.4 Sep 22, 2024
@akien-mga akien-mga merged commit b030638 into godotengine:master Sep 23, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants