-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for XR_FB_android_surface_swapchain_create
#208
Add support for XR_FB_android_surface_swapchain_create
#208
Conversation
74d2333
to
bfeacca
Compare
Taking this out of draft now that the Godot PR has been merged. However, this actually won't pass tests on the XR Simulator until after 4.4-dev3 is released and I change the CI to point to that, so I guess this will still need to wait a bit before we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minus my one little nit.
plugin/src/main/cpp/extensions/openxr_fb_android_surface_swapchain_create_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
bfeacca
to
2166ac9
Compare
2166ac9
to
027116e
Compare
FYI, this one is failing testing because of a bug in Godot 4.4-dev3 - see godotengine/godot#98102 It was fixed in PR godotengine/godot#98187 which is already merged and should be included in Godot 4.4-dev4. I'll update the CI to use 4.4-dev4 once it's released! |
858ac5f
to
83687e5
Compare
0177dfc
to
fc645f6
Compare
I've been trying to figure out why the XR Simulator tests on CI are crashing - here's some notes on it so far:
Anyway, it doesn't seem like the CI issues really have anything to do with this PR, but do seem to represent an issue with upstream Godot and the XR Simulator |
Unfortunately, it looks like a custom compiled UPDATE: It appears that builds with |
Once PR godotengine/godot#100471 is merged, and there's a new 4.4-dev release, and the CI is updated to use it - then this should finally pass CI :-) |
9fcff44
to
74b20d7
Compare
This is FINALLY passing tests! It already has approvals (based on the non-CI code) so I suppose I could merge it. :-) However, this will mean the |
74b20d7
to
183a512
Compare
This adds support for
XR_FB_android_surface_swapchain_create
which gives two new flags that can be used to customize the creation of Android surface swapchains.It depends on Godot PR godotengine/godot#97252 (so setting as a draft for now)
That means that this will require Godot 4.4, which is why it is also updating the
extension_api.json
and godot-cpp. After this is merged, then themaster
branch will only work with Godot 4.4 (relating to our discussion from the last XR team meeting).