Fix Mobile Renderer - Shadow Disabled and User Vertex Lighting flags #98187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncompatible with ubershader method definitions
EnlightenedOne
changed the title
EnlightenedOne
changed the title
|
Thank you. Will pull this to recompile the fork as soon as it is merged. Leaving this comment so as to not to forget. |
DarioSamo
approved these changes
Oct 17, 2024
|
Confirmed the issue and tested the PR to confirm it fixes it. Changes look good to me. |
|
Cool is anything else required to merge this? |
clayjohn
approved these changes
Oct 17, 2024
|
Thank you! And congratulations on your first merged pull request!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98102 Forward Mobile Renderer fix. Corrects preprocessor directive, also removes redefinition of method names as parameters which must predate the ubershader work.
To test toggle the two shader flags in Mobile mode and watch the console to confirm no fireworks, visual checks look good:
USE_VERTEX_LIGHTING - uber shader bug
Shadows Disabled - preprocessor order bug
Adjusted both here as the issue crept in under the vertex lighting change and I wanted to confirm no gremlins with the two interacting, was confused when I couldn't switch on the vertex lighting at all.