Fix AudioStreamPlayback's _stop() not being called when AudioStreamPlayer's stop() is called

[SourceOfHTML]

Small fix that resolves #97466 , although I am not very familiar with that part of the code, and where and how the line would be best implemented, because I have very little idea what the rest of the code in the relevant method is about. (Note: Done with assistance from anvilfolk in the Contributor's Chat)

[adamscott]

Hi there! Thanks for your first contribution! We're close, thanks to you!

[SourceOfHTML]

what issue does it specifically have with the code style, and how do I get to fixing it?

[adamscott]

what issue does it specifically have with the code style, and how do I get to fixing it?

I suggest that you install pre-commit and run pre-commit init inside the project before committing. It makes sure that style checks are done before CI.

I suggest that you run git commit --amend afterwards, it will run the pre-commit checks.

[adamscott]

Should be good to merge after the style checks. I tested it and it works well!

[SourceOfHTML]

Alright, I reckon the correct version of clang-tools is also necessary? One from https://github.com/llvm/llvm-project/releases/tag/llvmorg-17.0.1 ? I was putting off downloading clang-tools because I don't know which of the files in that list I should download

[adamscott]

what issue does it specifically have with the code style, and how do I get to fixing it?

I think it's because the in-between blank line has whitespace, just make sure that it's an empty line without tabs.

[adamscott]

Alright, I reckon the correct version of clang-tools is also necessary? One from https://github.com/llvm/llvm-project/releases/tag/llvmorg-17.0.1 ? I was putting off downloading clang-tools because I don't know which of the files in that list I should download

On which OS are you? You don't have to download the files manually.

[SourceOfHTML]

Windows, specifically Windows10

[adamscott]

Windows, specifically Windows10

I think that by installing LLVM with scoop, you'll be able to have clang-format.

[SourceOfHTML]

I got LLVM and clang-format, woo! Thank you!

[SourceOfHTML]

SORRY sorry that should not have happened, I'll revert it, apologies to all involved parties

nvm I dont know what I'm doing, I feel like anything else I'll do at this point will be another slip-up

[Zireael07]

At this point you've got to close this PR and remake it from scratch, you messed up rebasing

[SourceOfHTML]

RIght yes that makes sense, I'll do that at some point

[SourceOfHTML]

With the help of some people from the Contributor Chat, I undid the mess, and will make a note to keep my work organized on separate branches. Apologies again, to all involved who had to deal with my nonsense. There was no need to redo the PR tho, so yay for that.

[mhilbrunner]

Don't worry too much about it, everyone has to learn sometime and Git is a complicated beast. Thanks for contributing.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉