Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure MSAA properly in canvas renderer's pipelines. #97811

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Configure MSAA properly in canvas renderer's pipelines. #97811

merged 1 commit into from
Oct 4, 2024

Conversation

DarioSamo
Copy link
Contributor

Critical regression was introduced while refactoring canvas renderer in preparation for ubershaders.

Fixes #97800.

@DarioSamo DarioSamo requested a review from a team as a code owner October 4, 2024 13:48
@DarioSamo DarioSamo mentioned this pull request Oct 4, 2024
Closed
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 4, 2024
SaracenOne
SaracenOne approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Appears to fix the problem. LTGM 👍

@akien-mga akien-mga merged commit 41c55f0 into godotengine:master Oct 4, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

2D MSAA breaks rendering.
5 participants
@DarioSamo @akien-mga @SaracenOne @clayjohn @AThousandShips