-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make module dependency check recursive #97813
Make module dependency check recursive #97813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module logic in general could probably use a broad refactor; didn't realize just how messy it could get until I went to verify the changes
Nonetheless, the logic is sound and the changes work! Changing the container type should be fine, as I doubt anything is using that variable directly
The `env.disabled_modules` and `methods.disable_module` weren't used anywhere so the first one was repurposed and the second just deleted Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
1d32402
to
8e75e02
Compare
I would say it about half of the SCons itself.... Anyway, I don't know what messiness you noticed but I've noticed following:
def module_check_dependencies(self, module):
"""
...
Meant to be used in module `can_build` methods.
...
""" It is used only inside main
|
Thanks! |
Fixes #97812
The
env.disabled_modules
andmethods.disable_module
weren't used anywhere so the first one was repurposed and the second just deleted