-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS
#97866
Update CODEOWNERS
#97866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the super groups like @godotengine/_editor
actually work as such
I think super groups still work, as Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ones here look good I think, can't speak to missing cases but I think this is good to go
I HAVE THE POWER |
/servers/**/navigation* @godotengine/navigation | ||
/servers/**/physics* @godotengine/physics | ||
/servers/**/rendering* @godotengine/rendering | ||
/servers/**/text* @godotengine/gui-nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These filters seem to be too generic: e.g, change to servers/rendering/renderer_rd/storage_rd/texture_storage.cpp
trigger /servers/**/text*
not /servers/**/rendering*
and result in a wrong team assignment.
/servers/rendering/renderer_rd/storage_rd/texture_storage.cpp
/servers/** /text*
While the codeowner file is in a MUCH better spot than it was before, there was still quite a few edgecases that weren't fully accounted for. This PR attempts to address that by adding a few cases that were missing or weren't using wildcards appropriately. While this PR doesn't account for all of them, it ensures that there's a more appropriate baseline for many of these cases where
buildsystem
wasn't appropriate