Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CODEOWNERS corrections #98399

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 21, 2024

CODEOWNERS has been a bit too overzealous in catching review groups, so this PR mitigates that with two changes:

  • Revert adding _editor reviewers to editor folders in modules. Might revisit in the future, but it's more granular than expected.
  • Add underscore before wildcard for servers, preventing false positives.

@Repiteo Repiteo added this to the 4.4 milestone Oct 21, 2024
@Repiteo Repiteo requested a review from a team as a code owner October 21, 2024 22:17
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the meta-teams like @godotengine/_editor we might want to look at diversifying the teams in that, and we might want to remove some of the other meta-teams if they aren't working well

But looks good for that part, holding off approval until the servers part has been resolved

CC @bruvzg since you had some thoughts on the wildcard cases in the previous PR

@dalexeev
Copy link
Member

By the way:

1. Add missing . in line 3:

# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.
# Owners can be @users, @org/teams or emails

2. Add missing / in line 156:

godot/.github/CODEOWNERS

Lines 155 to 157 in b3bcb2d

/modules/jsonrpc/ @godotengine/gdscript @godotengine/network
/modules/jsonrpc/tests @godotengine/gdscript @godotengine/network @godotengine/tests
/modules/mono/ @godotengine/dotnet

@Repiteo Repiteo force-pushed the codeowners-2-return-of-jafar branch from a60cfd2 to 99ef817 Compare October 22, 2024 14:51
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work well now I think

@Repiteo Repiteo merged commit 9169ace into godotengine:master Oct 30, 2024
20 checks passed
@Repiteo Repiteo deleted the codeowners-2-return-of-jafar branch October 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants