Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EditorSpinSlider grabber TextureRect doesn't follow parent when scrolling. #97946

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

WhalesState
Copy link
Contributor

@WhalesState WhalesState requested review from a team as code owners October 7, 2024 18:35
@WhalesState WhalesState changed the title Fix EditorSpinSlider grapper TextureRect doesn't follow parent wh… Fix EditorSpinSlider grapper TextureRect doesn't follow parent when scrolling. Oct 7, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 9, 2024
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 9, 2024
@SaracenOne
Copy link
Member

SaracenOne commented Oct 10, 2024

Hmm, the fix seems mostly fine, but I'm a little concerned about hardcoding the z-value to 1. While I don't think the z-value would change for an EditorSpinSlider, wouldn't it still make more sense to make it something like grabber->set_z_index(get_z_index() + 1); so it's always relative?

Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous feedback was mistaken since all CanvasItems have z_relative set on by default, so this should be fine to merge as is after all 👍

@WhalesState WhalesState marked this pull request as draft October 18, 2024 20:20
@WhalesState WhalesState deleted the editor-spin-slider branch October 25, 2024 12:02
@AThousandShips AThousandShips added archived and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 25, 2024
@AThousandShips AThousandShips removed this from the 4.4 milestone Oct 25, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Oct 25, 2024

This is relatively simple and easy to salvage, too.

@mounirtohami mounirtohami restored the editor-spin-slider branch October 26, 2024 22:13
@WhalesState WhalesState reopened this Oct 26, 2024
@WhalesState WhalesState marked this pull request as ready for review October 26, 2024 22:20
@KoBeWi KoBeWi added this to the 4.4 milestone Oct 26, 2024
@akien-mga akien-mga requested a review from KoBeWi November 11, 2024 15:54
@AThousandShips AThousandShips changed the title Fix EditorSpinSlider grapper TextureRect doesn't follow parent when scrolling. Fix EditorSpinSlider grabber TextureRect doesn't follow parent when scrolling. Nov 11, 2024
@Repiteo Repiteo merged commit 9374e8d into godotengine:master Nov 12, 2024
39 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus "outline" for sliders moves with scrolling
7 participants