-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some folders which would benefit from scu to scu pipeline #98261
Conversation
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
9dcc8f8
to
8eeee92
Compare
Yes it's super possible that this will be a good idea, as there have been folder changes / new folders since the original SCU PR, and we may be missing out on speedup. I don't tend to monitor this much as I mainly work on Godot 3.x. Timings for full rebuilds before / after are particularly useful for this kind of thing. I'll try the PR. 👍 |
It is only several folders but they contain many files. Timings of my rebuilds usually take 30min so honestly it is not what I really want to measure (because to make consistent measurements I need 1h doing nothing with device)... I can make a screenshots of the build process where lots of lines are not scu... |
On my machine with clean builds: Before: 2mins 54 Some of the folders added won't make a whole lot of difference (where there are e.g. just 2 cpp files) but on the whole this seems worth doing. The checks indicate it compiles fine with different platforms but we should watch for any build regressions in the next few days after merging. Other than that it should be pretty safe if no name conflicts are detected by compiler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
Thanks! |
Used SCU and saw that some big/medium size folders aren't processed with SCU