Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touch screen events on Linux being misattributed to the main window #98314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexkar598
Copy link
Contributor

@alexkar598 alexkar598 commented Oct 18, 2024

Simple test case:
TouchTestCaseSrc.zip

System info on the machine i tested with

Operating System: Arch Linux
KDE Plasma Version: 6.1.5
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.3
Kernel Version: 6.11.1-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 5825U with Radeon Graphics
Memory: 15.0 GiB of RAM
Graphics Processor: AMD Radeon Graphics
Manufacturer: Dell Inc.
Product Name: Inspiron 16 5625
System Version: 1.10.0

Fixes #77653

@Sauermann
Copy link
Contributor

I would like to ask you to split your PR into two separate PRs, one for each bug. This would make it easier to review each change and would make it easier to handle regressions.

@alexkar598 alexkar598 changed the title Fixes for window_id and touch events Fixes touch screen events on Linux being misattributed to the main window Oct 18, 2024
@alexkar598
Copy link
Contributor Author

I would like to ask you to split your PR into two separate PRs, one for each bug. This would make it easier to review each change and would make it easier to handle regressions.

I split off the mouse emulation fix to another pr #98318 . That being said, the windows users(for who mouse emulation goes to the wrong window) in #77653 are not experiencing the same bug as the Linux users (who straight up don't receive the touch events in the right window)

@bruvzg bruvzg self-requested a review October 18, 2024 20:32
@AThousandShips AThousandShips changed the title Fixes touch screen events on Linux being misattributed to the main window Fix touch screen events on Linux being misattributed to the main window Oct 19, 2024
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce the issue, tested on PopOS 22.04 with touchscreen and Wacom table. It seems to work the same with or without this change.

@alexkar598
Copy link
Contributor Author

alexkar598 commented Oct 21, 2024

Can't reproduce the issue, tested on PopOS 22.04 with touchscreen and Wacom table. It seems to work the same with or without this change.

Heres a recording of the issue before and after the fix

linux_broken.mp4
linux_fixed.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touch input not being received by any Popups
3 participants