Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse emulation always sending events to the main window #98318

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix mouse emulation always sending events to the main window #98318

merged 1 commit into from
Oct 25, 2024
+2 −0

Conversation

alexkar598
Copy link
Contributor

Simple test case:
TouchTestCaseSrc.zip

System info on the machine i tested with

Operating System: Arch Linux
KDE Plasma Version: 6.1.5
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.3
Kernel Version: 6.11.1-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 5825U with Radeon Graphics
Memory: 15.0 GiB of RAM
Graphics Processor: AMD Radeon Graphics
Manufacturer: Dell Inc.
Product Name: Inspiron 16 5625
System Version: 1.10.0

Fixes #91099

@alexkar598 alexkar598 requested a review from a team as a code owner October 18, 2024 20:23
@Sauermann Sauermann added this to the 4.4 milestone Oct 18, 2024
@alexkar598 alexkar598 mentioned this pull request Oct 18, 2024
Open
Sauermann
Sauermann approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing window id is definitively a bug. I find it likely that this PR will resolve the linked issue, but I can't test it.
Implementation and code style are looking correct.

@AThousandShips AThousandShips changed the title Fixes mouse emulation always sending events to the main window Fix mouse emulation always sending events to the main window Oct 19, 2024
bruvzg
bruvzg approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with touchscreen and Wacom tablet on Windows, it works fine, but I can't reproduce the issue without this PR. Window ID changes look correct.

@alexkar598
Copy link
Contributor Author

Tested with touchscreen and Wacom tablet on Windows, it works fine, but I can't reproduce the issue without this PR. Window ID changes look correct.

Heres a recording of before and after the fix (with a touchscreen but admittedly over RDP)

windows_broken.mp4
windows_fixed.mp4

@clayjohn clayjohn merged commit f83a273 into godotengine:master Oct 25, 2024
20 checks passed
@clayjohn
Copy link
Member

Thank you!

@alexkar598 alexkar598 deleted the mouse_emulation branch October 25, 2024 12:10
@GNSS-Stylist GNSS-Stylist mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann

@bruvzg bruvzg

Assignees
No one assigned
Labels
bug topic:input
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Windows tablet (with touchscreen): Touches to non-embedded SubWindows are relayed to the main window
4 participants
@alexkar598 @clayjohn @Sauermann @bruvzg