Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add notes about C# differences in Variant constructors #98499

Merged

Conversation

tetrapod00
Copy link
Contributor

Fixes godotengine/godot-docs#10138.

The difference between C# and GDScipt was already noted in the Color default constructor. This PR adds similar notes to the other variant types with different default constructor behavior: Basis, Projection, Quaternion, Transform2D, Transform3D.

@tetrapod00 tetrapod00 requested a review from a team as a code owner October 24, 2024 21:51
@paulloz paulloz added this to the 4.4 milestone Oct 24, 2024
@tetrapod00 tetrapod00 force-pushed the docs-dotnet-constructor-differences branch from e41a500 to 7f3ee84 Compare October 24, 2024 23:07
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and one-ah more thing-

@tetrapod00 tetrapod00 force-pushed the docs-dotnet-constructor-differences branch from 4e8ab9d to c51cdaf Compare October 27, 2024 20:24
@AThousandShips AThousandShips changed the title Docs: Add note about C# differences in Variant constructors Docs: Add notes about C# differences in Variant constructors Oct 28, 2024
@Repiteo Repiteo merged commit 85c5a4f into godotengine:master Nov 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

@tetrapod00 tetrapod00 deleted the docs-dotnet-constructor-differences branch November 11, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect description of Transform3D empty constructor in the documentation
6 participants