Use surface extents for swap chain extents. #98780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdaven
commented
Nov 2, 2024
| @@ -2991,7 +2989,7 @@ Error RenderingDeviceDriverVulkan::swap_chain_resize(CommandQueueID p_cmd_queue, | |||
| swap_create_info.minImageCount = desired_swapchain_images; | |||
| swap_create_info.imageFormat = swap_chain->format; | |||
| swap_create_info.imageColorSpace = swap_chain->color_space; | |||
| swap_create_info.imageExtent = native_display_size; | |||
| swap_create_info.imageExtent = extent; | |||
There was a problem hiding this comment.
Line 2901 would handle the case of UINT32_MAX extents from GetPhysicalDeviceSurfaceCapabilitiesKHR that means "indicating that the surface size will be determined by the extent of a swapchain targeting the surface". This would be stored to native_display_size but then not updated when the others are handled.
Since native_display_size wasn't used anywhere else it was simple to just use the calculated extents instead.
akien-mga
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
I confirm this fixes the linked issue for me.
Still needs an OK from the @godotengine/rendering team.
CC @darksylinc
|
Hold off the merge for a little bit. I need to check if it's correct. The main issue is that on Android we will often get |
|
Last week a forum user reported this error, Android Editor
|
|
Hi
That problem is unrelated to this PR, please open a new ticket providing all the requested info so we can make a blocklist to disable swappy for that particular device(s). |
darksylinc
pushed a commit
to darksylinc/godot
that referenced
this pull request
Nov 5, 2024
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
|
This PR was fine, but I opened #98852 as there were a few details I detected while reviewing it. |
|
Superseded by #98852. Thanks for the contribution! |
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 9, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 9, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 9, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 10, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 13, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 13, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 15, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 16, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 20, 2025
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98779
This PR just uses the calculated surface extents instead of the current extents which are sometimes the special value UINT32_MAX.