Vulkan: Account for the case surface_capabilities.currentExtent is unset
#98852
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes godotengine#98779 It may also fix misc issues when resizing on all platforms. Superseedes PR godotengine#98780 , thanks to user tdaven for the original patch. PR godotengine#98780 would break Android support as it did not account that width and height might need to be swapped. Replaced manual swap by Godot's SWAP(), which indicates intention much easier.
This was referenced Nov 5, 2024
|
I can confirm this PR fixes #98779. I don't have an android setup so I can't test that behavior. But Fedora 41 Wayland session opens the editor fine with this PR. |
akien-mga
approved these changes
Nov 5, 2024
akien-mga
changed the title
surface_capabilities.currentExtent is unset
|
Built locally and tested on Android and it appears to work fine. I only tested one project on one device. But I suspect if there was any issue, it would have been clear |
|
Apologies for the late testing. I just tested 2 projects on Android and it looks like it's working fine. 😄 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wayland in particular sets surface_capabilities.currentExtent.width to the special value 0xFFFFFFFF, which is valid per spec. Fixes #98779
It may also fix misc issues when resizing on all platforms.
Superseedes PR #98780 , thanks to user @tdaven for the original patch. PR #98780 would break Android support as it did not account that width and height might need to be swapped.
Replaced manual swap by Godot's SWAP(), which indicates intention much easier.