-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update Linux runners to Ubuntu 24.04 #98898
Conversation
Hmm, so the minimum Python version that 22.04 supports is |
5d7e989
to
23a4fa4
Compare
Yeah Python 3.6 has been EOL for 3 years now, we can likely drop support for it too. Python 3.8 just went EOL, we could probably use it as our new min version and not cut off too many users on legacy distros or Python setups. |
23a4fa4
to
02d57e9
Compare
Testing locally, I also need to do this fix, like in my diff --git a/scene/2d/tile_map.cpp b/scene/2d/tile_map.cpp
index ddb0635f6b..1bfd1fed5a 100644
--- a/scene/2d/tile_map.cpp
+++ b/scene/2d/tile_map.cpp
@@ -75,7 +75,8 @@ void TileMap::_set_tile_map_data_using_compatibility_format(int p_layer, TileMap
for (int i = 0; i < c; i += offset) {
const uint8_t *ptr = (const uint8_t *)&r[i];
uint8_t local[12];
- for (int j = 0; j < ((p_format >= TileMapDataFormat::TILE_MAP_DATA_FORMAT_2) ? 12 : 8); j++) {
+ const int buffer_size = (p_format >= TileMapDataFormat::TILE_MAP_DATA_FORMAT_2) ? 12 : 8;
+ for (int j = 0; j < buffer_size; j++) {
local[j] = ptr[j];
}
For the PacketPeerUDP / RingBuffer stringop-overflow, I don't reproduce it locally with GCC 14 for some reason. diff --git a/core/io/packet_peer_udp.h b/core/io/packet_peer_udp.h
index c69a138c53..724a902960 100644
--- a/core/io/packet_peer_udp.h
+++ b/core/io/packet_peer_udp.h
@@ -49,7 +49,7 @@ protected:
uint8_t recv_buffer[PACKET_BUFFER_SIZE];
uint8_t packet_buffer[PACKET_BUFFER_SIZE];
IPAddress packet_ip;
- int packet_port = 0;
+ uint32_t packet_port = 0;
int queue_count = 0;
IPAddress peer_addr; |
Seems to be a requirement for #89660 because of GCC versions? |
You might be able to remove this, if Ubuntu 22.04 has a recent enough version of Mesa.
If not, the |
CI: Update Linux runners to Ubuntu 24.04
I'll keep this a draft until your implementation is merged, so I'll know what to reference In the meantime, I'll cook up a PR making 3.8 the minimum Python version Edit: badabing: |
Note that raising the requirement above Python 3.8 will break Pyston though, which I still rely upon as it allows for faster rebuilds. CPython 3.13 onwards is starting to focus on performance, but it's not at the level of Pyston yet. (There is also an experimental JIT, but it doesn't work with SCons.) Unfortunately, Pyston is unmaintained these days, so it won't see any support newer than Python 3.8. Sphinx has already dropped Python 3.8 support, but SCons still supports it for now. |
02d57e9
to
ddb8e8a
Compare
ddb8e8a
to
57326df
Compare
57326df
to
8d1462c
Compare
Thanks! |
Fix setting TileMap data compatibility format broken by #98898.
Today I've tested speed of Pyston in comparison to CPython and it is not so astonishing now. I've run builds on already built repo so it just needed to execute python: Pyston 2.3.5: ~17.5s And these are results of my low-end i3 which makes clean build 1.5 hours. I think you even won't notice any difference on your hardware. I even didn't try CPython 3.13 with enabled JIT... |
Updates Linux runners from 20.04/22.04 to 24.04. The only exception is
linux_builds
, going from 20.04 to 22.04, for the sake of artifact portability