Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum size to some debugger elements #99113

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Nov 12, 2024

Fixes how certain parts of the debuggers can be shrunk down to disappear, to look really messed up, or to be drawn wrong. Fixes #97786

image

image

image

@MewPurPur MewPurPur requested a review from a team as a code owner November 12, 2024 10:37
@AThousandShips AThousandShips added this to the 4.x milestone Nov 12, 2024
@hsvfan-jan
Copy link

Will this fix #97786, too?

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Nov 12, 2024

@hsvfan-jan The minimum size of the Breakpoints thingy is now enough to prevent you from being able to collapse it as much as you've shown, but I didn't change the default size. But still, this should address the issue, so I've edited the post to include this.

The second thing you've mentioned is likely a result of your theming. This is how it looks for me in 4.3:

image

So I'm not sure it's an issue, if you still think it is you should open a separate ticket.

@hsvfan-jan
Copy link

hsvfan-jan commented Nov 12, 2024

No, that'll be enough for me to fully close the ticket, thanks!

@Mickeon Mickeon modified the milestones: 4.x, 4.4 Nov 13, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Nov 13, 2024

Are there other bottom-panel sections that have similar minimum limits?

@hsvfan-jan
Copy link

Are there other bottom-panel sections that have similar minimum limits?

I think this part could benefit from a bit more width to not have the scroll bar by default. It's legible as is, though, and not as "high priority" as the breakpoints I opened the bug for.
Screenshot 2024-11-13 at 10 38 41

@Mickeon
Copy link
Contributor

Mickeon commented Nov 13, 2024

My question was more-so about most other panels. Because when the editor's window is very small, the minimum size will push the Inspector & other docks.
Either way, this PR is a good thing, but it needs to be as minimal as reasonable.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Nov 13, 2024

All of the minimum sizes I've modified add up to significantly less than the required UI in some of these sections, like the lines of buttons on top. The minimum sizes are very tame, just enough to not look messed up.

@akien-mga akien-mga requested a review from a team November 13, 2024 11:47
@akien-mga akien-mga merged commit 04882d7 into godotengine:master Nov 29, 2024
20 checks passed
@MewPurPur MewPurPur deleted the tweak-debugger-sizings branch November 29, 2024 21:56
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoints width is far too low, making it easily overlooked
5 participants