Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a code sample that extracts all files to ZIPReader documentation #99325

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 16, 2024

Tested with various ZIP files found on the web (e.g. from this page), with a single root folder or multiple files at its root.

Thanks @raulsntos for the original code sample, which I've modified to better handle various ZIP files I've tested.

@Calinou Calinou requested review from a team as code owners November 16, 2024 17:03
@Calinou Calinou added enhancement documentation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 16, 2024
@Calinou Calinou added this to the 4.4 milestone Nov 16, 2024
@Calinou Calinou force-pushed the doc-zipreader-extract-all branch from be46e1d to 58bb7b1 Compare November 16, 2024 17:05
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the sample code in 4.3 with a single ZIP archive, and it works as expected.

Tested with various ZIP files found on the web, with a single root
folder or multiple files at its root.

Co-authored-by: Raul Santos <raulsntos@gmail.com>
@Calinou Calinou force-pushed the doc-zipreader-extract-all branch from 58bb7b1 to 4db9c11 Compare December 2, 2024 23:37
@Repiteo Repiteo merged commit 47bc374 into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks!

@Calinou Calinou deleted the doc-zipreader-extract-all branch December 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants