Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of implicit static typing from the documentation #99924

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Dec 2, 2024

See #99325 (comment) and prior comments

TL:DR: We shouldn't use static typing in the documentation (unless it's relevant to the code example). At least not yet.

Use this opportunity to point out oddities within the affected descriptions. There always are.

@Mickeon Mickeon added this to the 4.4 milestone Dec 2, 2024
@Mickeon Mickeon requested review from a team as code owners December 2, 2024 14:44
@Mickeon Mickeon removed the request for review from a team December 2, 2024 14:44
@akien-mga akien-mga merged commit d741a64 into godotengine:master Dec 2, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@Mickeon
Copy link
Contributor Author

Mickeon commented Dec 2, 2024

10 minutes World Record

@Mickeon Mickeon deleted the documentation-no-implicit_static-typing-yet branch December 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants