Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit_elapse option to AnimationNodeTimeSeek to handle some processes #99348

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add explicit_elapse option to AnimationNodeTimeSeek to handle some processes #99348

merged 1 commit into from
Nov 22, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 17, 2024 •
edited
Loading

Add explicit_elapse option to handle is_external_seeking flag with AnimationNodeTimeSeek.

image

@TokageItLab TokageItLab added this to the 4.4 milestone Nov 17, 2024
@TokageItLab TokageItLab requested review from a team as code owners November 17, 2024 09:46
@TokageItLab TokageItLab changed the title Add explicit_elapse option to NodeSeek to handle some processes Add explicit_elapse option to AnimationNodeTimeSeek to handle some processes Nov 17, 2024
SaracenOne
SaracenOne approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was discussed and demonstrated in the Animation meeting and seems fine 👍

@Repiteo Repiteo requested a review from Mickeon November 19, 2024 16:08
AThousandShips
AThousandShips approved these changes Nov 20, 2024
View reviewed changes
@Repiteo Repiteo merged commit 0430b97 into godotengine:master Nov 22, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

@Mickeon Mickeon Awaiting requested review from Mickeon

Assignees
No one assigned
Labels
enhancement topic:animation
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Seek request processes root motion calculation always
4 participants
@TokageItLab @Repiteo @SaracenOne @AThousandShips