Unify y-flip behavior for sky in RD backends #99448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp
Outdated
Show resolved
Hide resolved
clayjohn
force-pushed
the
RD-sky-flip
branch
from
962cec2 to
02efdb2
Compare
BastiaanOlij
approved these changes
Nov 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #99193
Most of this PR is just cleanup. The original bug was a copy-paste error that we missed because the list of arguments to
setup_skywas so long. Almost all the arguments come straight from RenderDataRD, so we just pass a reference to that struct instead.The important change here is that we use the
depth_correctiony_flipinstead of manually doing a y flip in the shader. This way the sky will use the same logic as the scene and we don't have to maintain a bunch of hacks for alternative codepaths (like we had previously for ReflectionProbes)CC @BastiaanOlij