Fix broken includes when compiling with builtin_miniupnpc=false
#99556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 22, 2024
radiantgurl
approved these changes
Nov 22, 2024
akien-mga
changed the title
builtin_miniupnpc=false
Repiteo
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Will need a rebase, as well as a minor README.md tweak; otherwise, nice work!
thirdparty/README.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/thirdparty/README.md b/thirdparty/README.md
index 7a95e3c724..760ff0a1e6 100644
--- a/thirdparty/README.md
+++ b/thirdparty/README.md
@@ -628,7 +628,8 @@ to solve some MSVC warnings. See the patches in the `patches` directory.
Files extracted from upstream source:
-- Copy `miniupnpc/src` and `miniupnpc/include` to `thirdparty/miniupnpc`
+- `miniupnpc/src/` as `src/`
+- `miniupnpc/include/` as `include/miniupnpc/`
- Remove the following test or sample files:
`listdevices.c,minihttptestserver.c,miniupnpcmodule.c,upnpc.c,upnperrors.*,test*`
- `LICENSE`
ArchercatNEO
force-pushed
the
miniupnpc-include
branch
from
6237ea7 to
b33829f
Compare
ArchercatNEO
force-pushed
the
miniupnpc-include
branch
from
b33829f to
84bf1cc
Compare
akien-mga
approved these changes
Nov 27, 2024
Repiteo
approved these changes
Nov 27, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99196