Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Show TextureProgress radial center cross only when editing the scene #99870

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

arkology
Copy link
Contributor

Backport #99685 to 3.x to make everyone happy.
Closes #46266 Closes #96859

godot windows tools 64_sy7BmRR3eu

Verified

This commit was signed with the committer’s verified signature.
Repiteo Thaddeus Crews
@arkology arkology requested a review from a team as a code owner November 30, 2024 09:34
@arkology arkology changed the title Show TextureProgress radial center cross only when editing the scene [3.x] Show TextureProgress radial center cross only when editing the scene Nov 30, 2024
@Chaosus Chaosus added this to the 3.x milestone Nov 30, 2024
@lawnjelly
Copy link
Member

Although we often favour local solutions, in this case I'm wondering whether we should just backport is_part_of_edited_scene() function.

It may end up being used in multiple places (with more cherry picks), and it would be nice to have it centralized in case of future changes.

Other than that, this looks fine to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants