You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If 'dotnet tool' outputs non-ASCII characters and the system locale is
not 'utf-8', then 'update_deps.py' can fail due to UnicodeDecodeError.
This commit addresses the above issue by explicitly setting 'utf-8' when
calling subprocess.Popen.
Closesgoogle#1203
Description
python build_tools/update_deps.py
fails when the default locale iscp932
anddotnet tool
shows messages in Japanese.Rrerequisite
dotnet tool --help
shows messages in Japanesepython -c "import locale; print(locale.getpreferredencoding())"
showscp932
Steps to reproduce
Steps to reproduce the behavior:
git clone https://github.com/google/mozc.git
cd mozc
python build_tools/update_deps.py
Expected behavior
At the step 3, the command succeeds.
Actual behavior
At the step 3, the command fails with the following error.
Screenshots
Version or commit-id
14afac9
Environment
Additional context
We can fix the issue by adding
encoding='utf-8'
here.mozc/src/build_tools/update_deps.py
Lines 408 to 414 in 14afac9
The text was updated successfully, but these errors were encountered: