Decode messages from dotnet tool as UTF-8
#1204
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'dotnet tool' outputs non-ASCII characters and the system locale is not 'utf-8', then 'update_deps.py' can fail due to UnicodeDecodeError. This commit addresses the above issue by explicitly setting 'utf-8' when calling subprocess.Popen. Closes google#1203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
dotnet tooloutputs non-ASCII characters and the system locale is notutf-8, thenupdate_deps.pycan fail due toUnicodeDecodeError. This commit addresses the above issue by explicitly settingutf-8when callingsubprocess.Popen.Closes #1203
Issue IDs
python build_tools/update_deps.pyfails when the default locale iscp932anddotnet toolshows messages in Japanese #1203Steps to test new behaviors (if any)
dotnet tool --helpshows messages in Japanese.python -c "import locale; print(locale.getpreferredencoding())"showscp932python build_tools/update_deps.pyfinishes without any error.