Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python_mono_repo): clean up prerelease_deps and core_deps_from_source #2071

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 11, 2025

This PR will address feedback from code review in googleapis/google-cloud-python#13637. The following fixes are included:

  • Clean up of comments
  • Print out installed versions in prerelease_deps and core_deps_from_source
  • Sync dependencies in prerelease_deps and core_deps_from_source

@parthea parthea force-pushed the update-noxfile-monorepo branch from 7ffc8bd to 197bb5f Compare March 11, 2025 12:00
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 11, 2025
@parthea parthea force-pushed the update-noxfile-monorepo branch from 197bb5f to 3b890c6 Compare March 11, 2025 14:43
@parthea parthea marked this pull request as ready for review March 11, 2025 14:44
@parthea parthea requested review from chingor13 and a team as code owners March 11, 2025 14:44
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-trivial but minor comment about the try/catch.

@parthea parthea enabled auto-merge (squash) March 11, 2025 18:48
@parthea parthea merged commit 8897d22 into master Mar 11, 2025
10 checks passed
@parthea parthea deleted the update-noxfile-monorepo branch March 11, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants