3078 rate limit login #3216
Merged
3078 rate limit login #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
force-pushed
the
3078-rate-limit-login
branch
2 times, most recently
from
6c69668 to
6451284
Compare
mssalvatore
force-pushed
the
3078-rate-limit-login
branch
from
6451284 to
bf64672
Compare
9 tasks
ilija-lazoroski
approved these changes
Apr 10, 2023
cakekoa
reviewed
Apr 10, 2023
| @@ -123,8 +129,6 @@ def get_agent_binary(self, operating_system: OperatingSystem) -> bytes: | |||
| @handle_authentication_token_expiration | |||
| def get_otp(self) -> str: | |||
| response = self._http_client.get("/agent-otp") | |||
| if response.status_code == HTTPStatus.TOO_MANY_REQUESTS: | |||
| raise IslandAPIRequestLimitExceededError("Too many requests to get OTP.") | |||
There was a problem hiding this comment.
Doesn't the IslandAPIAgentOTPProvider still expect this error to be raised?
There was a problem hiding this comment.
Oh, I see, it's now handled by the HTTPClient decorator
There was a problem hiding this comment.
It gets raised from self._http_client.get() in the handle_island_errors() decorator.
This test fails against our Windows Island due to network latency issues. This is being removed until we can resolve the issue.
cakekoa
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue #3078
Adds rate limiting to authentication-related endpoints
PR Checklist
Testing Checklist
If applicable, add screenshots or log transcripts of the feature working