3078 test unauthenticated requests rejected #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+329
to
+345
| def test_unauthenticated_user_cannot_access_API(island): | ||
| island_requests = MonkeyIslandRequests(island) | ||
|
|
||
| assert ( | ||
| island_requests.post(AGENT_EVENTS_ENDPOINT, data=None).status_code | ||
| == HTTPStatus.UNAUTHORIZED | ||
| ) | ||
| assert ( | ||
| island_requests.post(AGENT_HEARTBEAT_ENDPOINT, data=None).status_code | ||
| == HTTPStatus.UNAUTHORIZED | ||
| ) | ||
| assert island_requests.put(PUT_LOG_ENDPOINT, data=None).status_code == HTTPStatus.UNAUTHORIZED | ||
| assert island_requests.get(GET_AGENT_PLUGINS_ENDPOINT).status_code == HTTPStatus.UNAUTHORIZED | ||
| assert ( | ||
| island_requests.get("/api/agent-plugins/plugin-type/plugin-name/manifest").status_code | ||
| == HTTPStatus.UNAUTHORIZED | ||
| ) | ||
| assert island_requests.get(GET_AGENT_SIGNALS_ENDPOINT).status_code == HTTPStatus.UNAUTHORIZED | ||
| assert ( | ||
| island_requests.post(GET_AGENTS_ENDPOINT, data=None).status_code == HTTPStatus.UNAUTHORIZED | ||
| ) | ||
| assert island_requests.get(GET_AGENT_EVENTS_ENDPOINT).status_code == HTTPStatus.UNAUTHORIZED | ||
| assert island_requests.get(PUT_LOG_ENDPOINT).status_code == HTTPStatus.UNAUTHORIZED | ||
| assert ( | ||
| island_requests.post(TERMINATE_AGENTS_ENDPOINT, data=None).status_code | ||
| == HTTPStatus.UNAUTHORIZED | ||
| ) |
There was a problem hiding this comment.
Long test. At least let's divide them by method: POST, GET, and PUT.
There was a problem hiding this comment.
I think an all around better approach would be to publish something like an OpenAPI spec and then redesign this test to programatically try all endpoints, but that's out of scope for this release.
There was a problem hiding this comment.
Breaking these up could result in a large number of login requests which is unnecessary. A whole lot of refactoring needs to happen in this file anyway. I say we just push it until later.
mssalvatore
force-pushed
the
3078-test-unauthenticated-requests-rejected
branch
from
bb68f97 to
ea5323c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a blackbox test to verify API rejects unauthenticated requests.
Merge after #3216
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?If applicable, add screenshots or log transcripts of the feature working