Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
googlesheets
package had stopped working, the code has been migrated togooglesheets4
. Also, all gsheet-IDs are now defined in one chunk inindex.Rmd
.Meanwhile, two data changes have taken place due to updates in gsheets:
HQ2190
has been split into two schemes@ToonHub can you update below code that you made earlier? By making a join between
attribute_1
andcode
, it has been assumed thatattribute_1
always refers to a type, the name of which is used to automatically generate scheme names innamelist
. However, currentlyattribute_1
in theschemes_MHQ
object contains a value2190_terr
asattribute_1
.n2khab/misc/generate_textdata/30_schemes_and_scheme_types.Rmd
Lines 569 to 584 in 86bd48c
This currently leads to an erroneous last line in
namelist.tsv
:https://github.com/inbo/n2khab/blob/googlesheets4_hq2190/inst/textdata/namelist.tsv#L612
In case you consider
attribute_1
to no longer always be a type name, please also update this in the documentation of theschemes
data source:n2khab/R/textdata.R
Lines 244 to 253 in 86bd48c
Preferably do these changes in a new pull request that branches from
googlesheets4_hq2190
and that targetsgooglesheets4_hq2190
, then you can add me as reviewer for that part.Assuming that you'll need to do some steps interactively, or by compiling the bookdown yourself (in the generate_textdata project):
renv
's R version is now upgraded to 4.1.1 and the package versions are more recent (exceptgit2rdata
, which has been frozen at 0.2.1 in order to avoid re-sorting many rows). Anyway therenv::restore()
line inindex.Rmd
should do its work.