[SYCL] removing std::memcpy from sycl headers #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l done in PR 1117.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
requested review from
a team,
dkhaldi,
YuriPlyakhin and
yubingex007-a11y
as code owners
joeatodd
requested changes
Oct 16, 2023
There was a problem hiding this comment.
As @YuriPlyakhin correctly points out, the use of std::memcpy in sycl/include/syclcompat/memory.hpp is host code copying host memory, so I think that should remain as std::memcpy.
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@cperkinsintel , Failed Tests (1): Could you please take a look? |
|
I think this might be causing the |
aelovikov-intel
added a commit
that referenced
this pull request
Dec 23, 2024
See #1117 and #11436 for the context. In this mode, `std::memcpy` cannot be used in device code, but its usage occasionally leaks into our code base. I think testing the configuration in CI is the easiest way to prevent that with at least some confidence. Another option would be to modify FE to report any usage of `std::memcpy` in device code only, but I don't know if that's even possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing std::memcpy from sycl headers, continuation of work originally done in #1117.