[SYCL][CI] Use -D_FORTIFY_SOURCE=2 in Nightly E2E CI
#16470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #1117 and #11436 for the context. In this mode, `std::memcpy` cannot be used in device code, but its usage occasionally leaks into our code base. I think testing the configuration in CI is the easiest way to prevent that with at least some confidence. Another option would be to modify FE to report any usage of `std::memcpy` in device code only, but I don't know if that's even possible.
|
Test run in https://github.com/intel/llvm/actions/runs/12474534716/job/34817029585 shows that it works and catches existing bugs. I'll prepare another PR with fix(es) and will rebase/rerun this once that other PR is merged. |
|
Had a discussion with @steffenlarsen about this. We decided that we'll wait until native device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1117 and
#11436 for the context.
In this mode,
std::memcpycannot be used in device code, but its usage occasionally leaks into our code base. I think testing the configuration in CI is the easiest way to prevent that with at least some confidence. Another option would be to modify FE to report any usage ofstd::memcpyin device code only, but I don't know if that's even possible.