[SYCL] Avoid overuse of CPU on wait read-write lock loop #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The while loop in lockSharedTimedMutex causes 100% usage of CPU if host apptication generates command groups in multiple threads That slow downs overall execution. Unify code of cleanupFinishedCommands fucntion with rest of module. Dead-lock is avoided by use of non-blocking lock operations.
|
/summary:run |
romanovvlad
reviewed
Sep 23, 2020
|
/summary:run |
s-kanaev
approved these changes
Sep 24, 2020
|
The changes look good. |
vladimirlaz
changed the title
Fixed PR description. It will be propagated to commit message on PR squash-and-merge. |
dm-vodopyanov
approved these changes
Sep 24, 2020
sergey-semenov
approved these changes
Sep 24, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Sep 29, 2020
…_wrapper * upstream/sycl: (1533 commits) [SYCL] XFAIL sub_group shuffle tests on GPU [SYCL] Add support for L0 loader validation layer (intel#2520) [NFC][LIT] Temporary disable function pointers as they hang on L0 (intel#2544) [SYCL] use release version of OpenCL ICD loader [SYCL] Improve testing of host-task (intel#2540) Revert 1291215 [SYCL] Fix warning caused by [[nodiscard]] attribute (intel#2545) [SYCL] Workaround windows build failure [SYCL] Remove kernel_signature_start from int header (intel#2537) [SYCL] Fix ABI tests in post-commit (intel#2539) [SYCL][DOC] Update C-CXX-StandardLibrary doc to align with latest status (intel#2529) [SYCL][NFC] Fix static code analysis concerns (intel#2531) [SYCL][NFC] Improve testing for accessor_property_list (intel#2532) [SYCL] Avoid overuse of CPU on wait read-write lock loop (intel#2525) [SYCL] Implement no-decomposition for kernel types that don't need it. (intel#2477) [SYCL] Add group algorithm constraints (intel#2462) [BuildBot] Uplift Windows GPU RT from 8673 to 8778 (intel#2533) [SYCL][LIT][NFC] Extend ABI test suite (intel#2522) [SYCL][DebugInfo] Reinstate source locations for some kernel instructions (intel#2527) [SYCL][NFC] Replace the deprecated VectorType::getNumElements() (intel#2524) ...
kbenzie
added a commit
to kbenzie/intel-llvm
that referenced
this pull request
Feb 17, 2025
Addition of num_compute_units query for device info
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Addition of num_compute_units query for device info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The while loop in lockSharedTimedMutex causes 100% usage of CPU
if host application generates command groups in multiple threads
That slow downs overall execution.