Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Silence a "local variable is initialized but not referenced" warning; NFC #3870

Merged
merged 1 commit into from
Jun 4, 2021
Merged

[SYCL] Silence a "local variable is initialized but not referenced" warning; NFC #3870

merged 1 commit into from
Jun 4, 2021

Conversation

AaronBallman
Copy link
Contributor

No description provided.

@AaronBallman
Copy link
Contributor Author

By some miracle, I happened to notice this one jump out from the hundreds of warnings generated by the SYCL pi.hpp header.

Build failures are config issues unrelated to the patch:

Cloning into 'vc-intrinsics-src'...
fatal: unable to access 'https://github.com/intel/vc-intrinsics.git/': Couldn't connect to server
Cloning into 'vc-intrinsics-src'...
fatal: unable to access 'https://github.com/intel/vc-intrinsics.git/': Couldn't connect to server
Cloning into 'vc-intrinsics-src'...
fatal: unable to access 'https://github.com/intel/vc-intrinsics.git/': Couldn't connect to server
-- Had to git clone more than once:
          3 times.
CMake Error at vc-intrinsics-subbuild/vc-intrinsics-populate-prefix/tmp/vc-intrinsics-populate-gitclone.cmake:31 (message):
  Failed to clone repository: 'https://github.com/intel/vc-intrinsics.git'

@AGindinson
Copy link
Contributor

AGindinson commented Jun 2, 2021 •
edited
Loading

Build failures are config issues unrelated to the patch.

These are; they seem to be happening in all PRs that are based off a relatively old revision (e.g. no such thing firing for #3869, which is only 14 commits behind intel/sycl).

@bader
Copy link
Contributor

bader commented Jun 3, 2021

Build failures are config issues unrelated to the patch.

These are; they seem to be happening in all PRs that are based off a relatively old revision (e.g. no such thing firing for #3869, which is only 14 commits behind intel/sycl).

I don't think failures are related to the base version. Buildbot merges tip of the sycl branch before building the compiler, so base version should be irrelevant.
Here is the example of such issue for the branch branched from from the tip of the sycl branch: branch - https://github.com/intel/llvm/tree/private/ansotkin/fix-duplicate-pointers
Log - http://ci.llvm.intel.com:8010/#/builders/37/builds/9196

@tfzhu, @pvchupin, any ideas what could be wrong here?

@pvchupin
Copy link
Contributor

pvchupin commented Jun 3, 2021

Build failures are config issues unrelated to the patch.

These are; they seem to be happening in all PRs that are based off a relatively old revision (e.g. no such thing firing for #3869, which is only 14 commits behind intel/sycl).

I don't think failures are related to the base version. Buildbot merges tip of the sycl branch before building the compiler, so base version should be irrelevant.
Here is the example of such issue for the branch branched from from the tip of the sycl branch: branch - https://github.com/intel/llvm/tree/private/ansotkin/fix-duplicate-pointers
Log - http://ci.llvm.intel.com:8010/#/builders/37/builds/9196

@tfzhu, @pvchupin, any ideas what could be wrong here?

It looks like bot connection problem to me. Basically git clone doesn't work because can't get to the deps source repo. @tfzhu, can you take a look?

@pvchupin
Copy link
Contributor

pvchupin commented Jun 3, 2021

Restart helped, but we probably have this intermittent issue in any case.

@bader bader merged commit ce1c5a4 into intel:sycl Jun 4, 2021
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jun 4, 2021
Merge branch 'sycl' into group_barrier
614a0c4 
* sycl: (320 commits)
  [SYCL] Silence a "local variable is initialized but not referenced" warning; NFC (intel#3870)
  [SYCL] Improve SYCL_DEVICE_ALLOWLIST (intel#3826)
  [SPIR-V] Change return value of mapType function (intel#3871)
  [SYCL] Fix post-commit failure in handler.hpp from unused-parameters. (intel#3874)
  [Driver][SYCL] Do not imply defaultlib msvcrt for Linux based driver on Windows (intel#3827)
  [SYCL] Unique stable name rebase (intel#3835)
  [SYCL] Align behavior of empty command groups with SYCL2020 (intel#3822)
  [SYCL][ESIMD] Make typenames and constants consistent with SYCL API style. (intel#3850)
  [SYCL] Allow __failed_assertion to support libstdc++-11 (intel#3774)
  [SYCL] Refactor stream class handing implementation (intel#3646)
  [SYCL] Fix syntax error introduced in intel#3401 (intel#3861)
  [SYCL] SYCL 2020 sub_group algorithms (intel#3786)
  [Buildbot][NFC] Add option to use LLD as linker (intel#3866)
  Revert "Emit correct location lists with basic block sections."
  [SPIRITTAnnotations] Fix debug info for ITT calls. (intel#3829)
  [SYCL][Doc] Fix build of Sphinx docs (intel#3863)
  [SYCL][FPGA][NFC] Tidy up intel_fpga_reg codegen test (intel#3810)
  [CODEOWNERS] Fix SPIRITTAnnnotations tests ownership (intel#3859)
  [SYCL][ESIMD] Host-compile simd.cpp test, fix errors & warnings. (intel#3846)
  [SYCL] Store pointers to memory allocations instead of iterators (intel#3860)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGindinson AGindinson AGindinson approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AaronBallman @AGindinson @bader @pvchupin @mdtoguchi