Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][FPGA][NFC] Tidy up intel_fpga_reg codegen test #3810

Merged

Conversation

mlychkov
Copy link
Contributor

Checks for Clang::CodeGenSYCL/intel-fpga-reg.cpp test were autogenerated
to speed up fixing of LIT tests failures after a patch
"[SYCL] Refactor address space handling in CodeGen library (#2864)".

Reorganize test code and tidy up checks to improve readability.

Signed-off-by: Mikhail Lychkov mikhail.lychkov@intel.com

@mlychkov mlychkov force-pushed the private/mlychkov/simplify_codegen_fpga_reg_test branch from f493aec to 84df593 Compare May 25, 2021 10:48
MrSidims
MrSidims previously approved these changes May 25, 2021
erichkeane
erichkeane previously approved these changes May 25, 2021
Copy link
Contributor

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sane to me. I just did a spot-check, so someone else might need to poke at the check-lines.

bader
bader previously approved these changes May 25, 2021
@mlychkov mlychkov dismissed stale reviews from bader, erichkeane, and MrSidims via 9592c78 May 26, 2021 20:18
Checks for Clang::CodeGenSYCL/intel-fpga-reg.cpp test were autogenerated
to speed up fixing of LIT tests failures after a patch
"[SYCL] Refactor address space handling in CodeGen library (intel#2864)".

Reorganize test code and tidy up checks to improve readability.

Signed-off-by: Mikhail Lychkov <mikhail.lychkov@intel.com>
@mlychkov mlychkov force-pushed the private/mlychkov/simplify_codegen_fpga_reg_test branch from 9592c78 to 75563eb Compare May 27, 2021 14:53
@bader bader merged commit 1c58522 into intel:sycl Jun 2, 2021
@mlychkov mlychkov deleted the private/mlychkov/simplify_codegen_fpga_reg_test branch June 2, 2021 10:37
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jun 4, 2021
* sycl: (320 commits)
  [SYCL] Silence a "local variable is initialized but not referenced" warning; NFC (intel#3870)
  [SYCL] Improve SYCL_DEVICE_ALLOWLIST (intel#3826)
  [SPIR-V] Change return value of mapType function (intel#3871)
  [SYCL] Fix post-commit failure in handler.hpp from unused-parameters. (intel#3874)
  [Driver][SYCL] Do not imply defaultlib msvcrt for Linux based driver on Windows (intel#3827)
  [SYCL] Unique stable name rebase (intel#3835)
  [SYCL] Align behavior of empty command groups with SYCL2020 (intel#3822)
  [SYCL][ESIMD] Make typenames and constants consistent with SYCL API style. (intel#3850)
  [SYCL] Allow __failed_assertion to support libstdc++-11 (intel#3774)
  [SYCL] Refactor stream class handing implementation (intel#3646)
  [SYCL] Fix syntax error introduced in intel#3401 (intel#3861)
  [SYCL] SYCL 2020 sub_group algorithms (intel#3786)
  [Buildbot][NFC] Add option to use LLD as linker (intel#3866)
  Revert "Emit correct location lists with basic block sections."
  [SPIRITTAnnotations] Fix debug info for ITT calls. (intel#3829)
  [SYCL][Doc] Fix build of Sphinx docs (intel#3863)
  [SYCL][FPGA][NFC] Tidy up intel_fpga_reg codegen test (intel#3810)
  [CODEOWNERS] Fix SPIRITTAnnnotations tests ownership (intel#3859)
  [SYCL][ESIMD] Host-compile simd.cpp test, fix errors & warnings. (intel#3846)
  [SYCL] Store pointers to memory allocations instead of iterators (intel#3860)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants