-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sales Order Shipment Search #8992
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8992 +/- ##
==========================================
- Coverage 85.50% 85.47% -0.04%
==========================================
Files 1176 1176
Lines 52012 52081 +69
Branches 2114 2113 -1
==========================================
+ Hits 44473 44515 +42
- Misses 7009 7032 +23
- Partials 530 534 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks @fuzeman
This looks nice! I would suggest that you add a playwright test for this, which would act as an end-to-end test for the new API features and UI integration. |
I haven't had much luck getting frontend tests running locally and will need to revisit this tomorrow. Not sure how the development environment should be set up for testing as it appears that the frontend tests need to be run outside the dev container or playwright will fail to launch. Proceeding to install frontend dependencies and playwright outside the dev container will allow for the playwright UI to be opened, but running tests presents a bunch of timeout errors and stalled tests trying to load pages. Am I missing something here? |
210872e
to
d4c0c99
Compare
I've added tests for search by tracking number and invoice number to I finally got tests running, but discovered the first
I haven't included any changes in regards to this issue, guessing something is still partially broken in my development environment. |
d4c0c99
to
2a7fb36
Compare
@SchrodingersGat I've rebased on master. I tracked down my issue running frontend tests was due to cookies being blocked as I've found tests appear to be a bit unreliable though - timing out sometimes, and passing other times. Looks like it just stalls during page navigation for some reason. |
@fuzeman yes there are some race conditions due to the tests running in parallel - I am trying to clean it up and get them running more reliably. The more tests we add, the worse the problem is becoming! |
@fuzeman thanks for the addition! |
Fixes searching in the sales order shipment template editor preview and enables searching from the search drawer. I think this will be very helpful when you need to find shipments by invoice or tracking number.