-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debounce checkLoginState
(testing reliability)
#9012
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9012 +/- ##
==========================================
- Coverage 85.55% 85.50% -0.05%
==========================================
Files 1177 1177
Lines 52014 52015 +1
Branches 2114 2114
==========================================
- Hits 44502 44478 -24
- Misses 6978 7004 +26
+ Partials 534 533 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@fuzeman thanks for looking into this, I really appreciate it. The fix looks pretty clean to me, and having tested it locally it does appear to be more "stable". Fingers crossed that this addresses a good part of our race condition related issues! |
@fuzeman thanks for the contribution 😁 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
I'll take a look at the other playwright test failures as well. I noticed some test failures had 401 Unauthorized ("Invalid token.") logged in the console, not sure if that's relevant yet though. |
@fuzeman that is normal for some runs (login tests for example) |
Had a closer look at the issue I was experiencing with tests stalling in #8992 and tracked it down to a redirection issue during login. I'm not sure if this is the best way to go about fixing this issue, ideally fixing this without a time delay would probably be better. Let me know what you think.
As displayed in the screenshots below: two
checkLoginState
calls are being fired as of 1b5019b, this can intermittently cause an unexpected redirection back to /home after playwright has clicked a tab on the header which in-turn stalls the test until timeout.master / 1b5019b (test successful)
master / 1b5019b (test stalled)
PR / c180469 (test successful)