-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate cli related components #403
Conversation
b35f14e
to
eb3bab8
Compare
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
eb3bab8
to
0688d8c
Compare
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
0688d8c
to
024ad23
Compare
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
024ad23
to
9cc8b0b
Compare
I am currently resolving #382 in this PR. As the final step, I plan to remove One of the requirements from the certifier is to provide a C API that allows access to the RIM value and the Realm’s Challenge from the attestation report. // certifier
rv = islet_parse(CLAIM_TITLE_RIM,
claims,
claims_len,
measurement_out,
measurement_out_size);
return rv == ISLET_SUCCESS; I have been using // islet-sdk
#[no_mangle]
pub unsafe extern "C" fn islet_parse(
title: *const c_char,
claims: *const c_uchar,
claims_len: c_int,
value_out: *mut c_uchar,
value_out_len: *mut c_int,
) -> islet_status_t {
let do_parse = || -> Result<(), Error> {
...
match parse(&claims, title) {
Some(ClaimData::Bstr(value)) => {
...
} To address this, I believe there are two possible approaches:
Could you share which approach do you prefer? |
@bitboom I would prefer the 2nd option, bacause |
@bitboom I'm not sure I understand. You need to extract the RIM and the challenge from the token? Because if that is the case you don't need to make any changes to the |
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
I found the way to extract let realm_claims = RealmClaims::from_raw_claims(&claims.realm_claims.token_claims, &claims.realm_claims.measurement_claims)?;
let plat_claims = PlatClaims::from_raw_claims(&claims.platform_claims.token_claims)?; |
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
345c465
to
22f3ae0
Compare
This PR deprecates
cli
and use rsictl as is. (Fixed #382.)tools/rsictl
as a submodulerust-rsi
atsdk