Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cli related components #403

Merged
merged 5 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ jobs:
- name: Check local packages and all of its dependencies for errors
run: >
cargo check --workspace
--exclude islet_sdk
--exclude islet_sdk --exclude rsictl
--exclude cose --exclude cca_token
--exclude ciborium
--exclude islet_mc_harnesses
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,6 @@
[submodule "third-party/dtc"]
path = third-party/dtc
url = https://git.kernel.org/pub/scm/utils/dtc/dtc.git
[submodule "tools/rsictl"]
path = tools/rsictl
url = https://github.com/islet-project/rsictl.git
48 changes: 48 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@ members = [
"lib/armv9a",
"lib/cca-token", # To be deprecated
"lib/cose",
"lib/io",
"lib/safe-abstraction",
"lib/vmsa",
"lib/uart",
"lib/io",
"lib/vmsa",
"model-checking",
"plat/fvp",
"realm/rsi-test",
"rmm/",
"sdk",
"model-checking",
"tools/rsictl",
]

[profile.dev]
Expand Down
4 changes: 2 additions & 2 deletions realm/linux-rsi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export PATH := ${ROOT}/assets/toolchain/aarch64-none-linux-gnu/bin:${PATH}
export CROSS_COMPILE := aarch64-none-linux-gnu-
export ARCH := arm64

CMDLINE = ${ROOT}/cli
CMDLINE = ${ROOT}/tools/rsictl
HEADERS = rsi.h

obj-m += rsi.o
Expand All @@ -19,7 +19,7 @@ module: ${HEADERS}
cp rsi.ko ${SHARED_DIR}

cmdline:
cd ${CMDLINE}; make aarch64
cargo install --path "${CMDLINE}" --root "${SHARED_DIR}" --target aarch64-unknown-linux-gnu

clean:
make -C ${KERNEL_DIR} M=${HERE} clean
Expand Down
1 change: 0 additions & 1 deletion scripts/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
REALM = os.path.join(ROOT, "realm")
RMM = os.path.join(ROOT, "plat/fvp")
SDK = os.path.join(ROOT, "sdk/")
CLI = os.path.join(ROOT, "cli/")
RSI_KO = os.path.join(ROOT, "realm/linux-rsi")
EXAMPLES = os.path.join(ROOT, "examples")
HES = os.path.join(ROOT, "hes")
Expand Down
1 change: 1 addition & 0 deletions scripts/deps/assets.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ ROOT=$(git rev-parse --show-toplevel)
cd $ROOT && git submodule update --init --depth 1 assets
git submodule update --init --depth 1 $ROOT/third-party/ciborium
git submodule update --init --depth 1 $ROOT/third-party/coset
git submodule update --init --depth 1 $ROOT/tools/rsictl
5 changes: 0 additions & 5 deletions scripts/fvp-cca
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ def prepare_sdk():
print("[!] Building RSI kernel module...")
make(RSI_KO)

def prepare_cli():
print("[!] Building CLI...")
make(CLI)

def prepare_islet_hes():
print("[!] Building islet-hes... ")
run(["cargo", "build", "--release"], cwd=HES_APP)
Expand Down Expand Up @@ -709,7 +705,6 @@ if __name__ == "__main__":
place_realm_at_shared(args.rmm, args.realm_ip, args.fvp_tap_ip, args.fvp_ip, args.no_kvm_unit_tests, args.no_prebuilt_ml)
if args.no_sdk is False:
prepare_sdk()
prepare_cli()

if not args.build_only and args.hes:
signal.signal(signal.SIGTERM, custom_signal_handler)
Expand Down
2 changes: 1 addition & 1 deletion scripts/init_min.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ HERE=$ROOT/scripts
# Install packages
$HERE/deps/pkgs-for-ci.sh

# Sync submodules (only assets, tf-a, ciborium, and coset)
git submodule update --init --depth 1 $ROOT/assets
git submodule update --init --depth 1 $ROOT/third-party/tf-a
git submodule update --init --depth 1 $ROOT/third-party/ciborium
git submodule update --init --depth 1 $ROOT/third-party/coset
git submodule update --init --depth 1 $ROOT/tools/rsictl

# Install rust
$HERE/deps/rust.sh
Expand Down
2 changes: 1 addition & 1 deletion scripts/init_min_acs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ HERE=$ROOT/scripts
# Install packages
$HERE/deps/pkgs-for-ci.sh

# Sync submodules (only assets, tf-a, acs, ciborium, and coset)
git submodule update --init --depth 1 $ROOT/assets
git submodule update --init --depth 1 $ROOT/third-party/tf-a
git submodule update --init --depth 1 $ROOT/third-party/cca-rmm-acs
git submodule update --init --depth 1 $ROOT/third-party/ciborium
git submodule update --init --depth 1 $ROOT/third-party/coset
git submodule update --init --depth 1 $ROOT/tools/rsictl

# Install rust (min)
$HERE/deps/rust_min.sh
Expand Down
1 change: 1 addition & 0 deletions tools/rsictl
Submodule rsictl added at cb9f97