-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DrawIO Icon does not work in KDE after installation with AppImager #547
Comments
This is still happening in the Linux build (Arch Linux in my case), app version 16.1.2. I'm not sure why this issue got closed? Is it a duplicate? From what I can tell it's not a packaging error. |
We closed because we have no solution. We can re-open and have no solution if preferred :) |
It has the issue with only installation with AppImager . |
Create and Create and Create drawio.desktop in the directory
|
@davidjgraph @Zesko /usr/share/applications/drawio.desktop[Desktop Entry]
Name=drawio
Exec=/opt/drawio/drawio %U
Terminal=false
Type=Application
Icon=drawio
StartupWMClass=drawio
Comment=diagrams.net desktop
MimeType=application/vnd.jgraph.mxfile;application/vnd.visio;
Categories=Graphics; And both the However, having the correct How draw.io/diagrams.net desktop currently behaves (version 16.1.2)drawio-wrong-behavior.mp4As we can see, there are two problems here, probably related to each other:
How application should behave (another Electron app, Logseq)logseq-correct-behavior.mp4As I wrote, I thought the behavior might be related to some of Electron's quirks, so I found an Electron app who is doing this right - Logseq, a great PKM tool. As we can see here, the app both keeps its proper icon after launch and lets KDE associate its window with its launcher icon. Now if only I knew enough about Electron and JS to dive into code of both Logseq desktop and draw.io desktop to compare what the first is doing right, I could probably write a PR for this issue - but sadly I don't. This could be a helpful starting point for someone else, though. |
After digging in a bit more, I found that drawio is using I tested one other popular app from github, also built using |
I'm happy to report that I successfully solved this issue! All it took was adding a single line to icon: `${__dirname}/images/drawlogo256.png`, From what I understood, the problem is that Linux binaries don't have a special place to put their icon in (unlike Mac or Win), so specifying the icon in code is required for it to work. Adding this parameter changed the draw.io behavior to the correct one, fixing both the empty icon issue and the taskbar pinned icon matching issue: drawio-correct-behavior.mp4I linked I'll submit a PR shortly with this change. Huge thanks to Timosh from Electron Discord channel who helped me figure out the cause of the issue. |
Nice, thanks for looking. |
Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue.
* Fix problem with C4 diagraming tool Related issue: #2345 * 15.7.0 release * 15.7.1 release * 15.7.2 release * 15.7.3 release * 15.7.4 release * 15.8.0 release * 15.8.1 release * 15.8.3 release * 15.8.4 release * 15.8.5 release * 15.8.6 release * 15.8.7 release * 15.8.8 release * Add files via upload * 15.8.9 release * 15.8.9 release * 15.8.9 release * 15.9.1 release * 15.9.3 release * 15.9.4 release * 15.9.5 release * 15.9.6 release * 16.0.0 release * Update bug_report.md * 16.0.2 release * 16.0.3 release * 16.1.0 release * 16.1.2 release * Update README.md * 16.1.3 release * 16.1.4 release * 16.2.1 release * 16.2.2 release * 16.2.3 release * 16.2.4 release * Update stale.yml * 16.2.6 release * Create bug_report.yaml * Delete bug_report.md * Update bug_report.yaml * Update bug_report.yaml * Create feature_request.yaml * Delete feature_request.md * Update feature_request.yaml * 16.2.7 release * Fix incorrect application icon behavior on Linux Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue. * 16.3.0 release * 16.4.0 release * 16.4.3 release * 16.4.5 release * Bump node-fetch from 3.0.0 to 3.1.1 in /etc/propgen Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 3.0.0 to 3.1.1. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v3.0.0...v3.1.1) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * 16.4.7 release * 16.4.8 release * 16.4.11 release * 16.5.1 release * 16.5.2 release * 16.5.3 release * fix: upgrade electron-updater from 4.3.9 to 4.6.5 Snyk has created this PR to upgrade electron-updater from 4.3.9 to 4.6.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/davidjgraph/project/b324f40d-74b4-4545-99b2-af8481e33ed3?utm_source=github&utm_medium=referral&page=upgrade-pr * fix: upgrade electron-log from 4.4.1 to 4.4.4 Snyk has created this PR to upgrade electron-log from 4.4.1 to 4.4.4. See this package in npm: See this project in Snyk: https://app.snyk.io/org/davidjgraph/project/b324f40d-74b4-4545-99b2-af8481e33ed3?utm_source=github&utm_medium=referral&page=upgrade-pr * 16.5.4 release * 16.5.6 release * 16.6.0 release * 16.6.1 release * 16.6.2 release * 16.6.3 release * 16.6.4 release * 16.6.5 release * 16.6.6 release * 16.6.7 release * 16.6.8 release * 17.0.0 release * 17.1.0 release * 17.1.1 release * 17.1.2 release * 17.1.3 release * 17.1.3 release * 17.1.4 release * 17.1.5 release * 17.2.1 release * Fix loading order for javax.cache.CacheManager on App Engine I was running an drawio fork on app engine and Google Drive integration suddenly started failing with IncompatibleClassChangeError errors. Found https://stackoverflow.com/q/46582783 which fixed it. We might not 100% need this. This is mostly a heads up if anyone else runs into similar issues. I'm also not sure if this is easily reproducible on the public App Engine. Following up with GAE to see if this is a bigger issue. * 17.2.1 release * Create codeql-analysis.yml * Create SECURITY.md * Update SECURITY.md * Update codeql-analysis.yml * Update codeql-analysis.yml * 17.2.2 release * Update codeql-analysis.yml * 17.2.3 release * 17.2.4 release * 17.2.5 release * 17.3.0 release * 17.4.0 release * 17.4.1 release * 17.4.2 release * 17.4.3 release * 17.4.3 release * Added java build for codeql * github: remove original repo configuration Co-authored-by: Dong Nguyen <ndaidong@gmail.com> Co-authored-by: David Benson [draw.io] <david@jgraph.com> Co-authored-by: Mate Egri <mate.egri78@gmail.com> Co-authored-by: David Benson <david@draw.io> Co-authored-by: Lukasz D <lukasz.dobrogowski@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: David Stephan <stephandavid3@gmail.com> Co-authored-by: Mohamed Mohamedin <ashraf.teleb85@gmail.com>
Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue.
* Fix problem with C4 diagraming tool Related issue: #2345 * 15.7.0 release * 15.7.1 release * 15.7.2 release * 15.7.3 release * 15.7.4 release * 15.8.0 release * 15.8.1 release * 15.8.3 release * 15.8.4 release * 15.8.5 release * 15.8.6 release * 15.8.7 release * 15.8.8 release * Add files via upload * 15.8.9 release * 15.8.9 release * 15.8.9 release * 15.9.1 release * 15.9.3 release * 15.9.4 release * 15.9.5 release * 15.9.6 release * 16.0.0 release * Update bug_report.md * 16.0.2 release * 16.0.3 release * 16.1.0 release * 16.1.2 release * Update README.md * 16.1.3 release * 16.1.4 release * 16.2.1 release * 16.2.2 release * 16.2.3 release * 16.2.4 release * Update stale.yml * 16.2.6 release * Create bug_report.yaml * Delete bug_report.md * Update bug_report.yaml * Update bug_report.yaml * Create feature_request.yaml * Delete feature_request.md * Update feature_request.yaml * 16.2.7 release * Fix incorrect application icon behavior on Linux Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue. * 16.3.0 release * 16.4.0 release * 16.4.3 release * 16.4.5 release * Bump node-fetch from 3.0.0 to 3.1.1 in /etc/propgen Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 3.0.0 to 3.1.1. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v3.0.0...v3.1.1) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * 16.4.7 release * 16.4.8 release * 16.4.11 release * 16.5.1 release * 16.5.2 release * 16.5.3 release * fix: upgrade electron-updater from 4.3.9 to 4.6.5 Snyk has created this PR to upgrade electron-updater from 4.3.9 to 4.6.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/davidjgraph/project/b324f40d-74b4-4545-99b2-af8481e33ed3?utm_source=github&utm_medium=referral&page=upgrade-pr * fix: upgrade electron-log from 4.4.1 to 4.4.4 Snyk has created this PR to upgrade electron-log from 4.4.1 to 4.4.4. See this package in npm: See this project in Snyk: https://app.snyk.io/org/davidjgraph/project/b324f40d-74b4-4545-99b2-af8481e33ed3?utm_source=github&utm_medium=referral&page=upgrade-pr * 16.5.4 release * 16.5.6 release * 16.6.0 release * 16.6.1 release * 16.6.2 release * 16.6.3 release * 16.6.4 release * 16.6.5 release * 16.6.6 release * 16.6.7 release * 16.6.8 release * 17.0.0 release * 17.1.0 release * 17.1.1 release * 17.1.2 release * 17.1.3 release * 17.1.3 release * 17.1.4 release * 17.1.5 release * 17.2.1 release * Fix loading order for javax.cache.CacheManager on App Engine I was running an drawio fork on app engine and Google Drive integration suddenly started failing with IncompatibleClassChangeError errors. Found https://stackoverflow.com/q/46582783 which fixed it. We might not 100% need this. This is mostly a heads up if anyone else runs into similar issues. I'm also not sure if this is easily reproducible on the public App Engine. Following up with GAE to see if this is a bigger issue. * 17.2.1 release * Create codeql-analysis.yml * Create SECURITY.md * Update SECURITY.md * Update codeql-analysis.yml * Update codeql-analysis.yml * 17.2.2 release * Update codeql-analysis.yml * 17.2.3 release * 17.2.4 release * 17.2.5 release * 17.3.0 release * 17.4.0 release * 17.4.1 release * 17.4.2 release * 17.4.3 release * 17.4.3 release * Added java build for codeql * remove git workflow original repo Co-authored-by: Dong Nguyen <ndaidong@gmail.com> Co-authored-by: David Benson [draw.io] <david@jgraph.com> Co-authored-by: Mate Egri <mate.egri78@gmail.com> Co-authored-by: David Benson <david@draw.io> Co-authored-by: Lukasz D <lukasz.dobrogowski@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: David Stephan <stephandavid3@gmail.com> Co-authored-by: Mohamed Mohamedin <ashraf.teleb85@gmail.com>
* Fix problem with C4 diagraming tool Related issue: #2345 * 15.7.0 release * 15.7.1 release * 15.7.2 release * 15.7.3 release * 15.7.4 release * 15.8.0 release * 15.8.1 release * 15.8.3 release * 15.8.4 release * 15.8.5 release * 15.8.6 release * 15.8.7 release * 15.8.8 release * Add files via upload * 15.8.9 release * 15.8.9 release * 15.8.9 release * 15.9.1 release * 15.9.3 release * 15.9.4 release * 15.9.5 release * 15.9.6 release * 16.0.0 release * Update bug_report.md * 16.0.2 release * 16.0.3 release * 16.1.0 release * 16.1.2 release * Update README.md * 16.1.3 release * 16.1.4 release * 16.2.1 release * 16.2.2 release * 16.2.3 release * 16.2.4 release * Update stale.yml * 16.2.6 release * Create bug_report.yaml * Delete bug_report.md * Update bug_report.yaml * Update bug_report.yaml * Create feature_request.yaml * Delete feature_request.md * Update feature_request.yaml * 16.2.7 release * Fix incorrect application icon behavior on Linux Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue. * 16.3.0 release * 16.4.0 release * 16.4.3 release * 16.4.5 release * Bump node-fetch from 3.0.0 to 3.1.1 in /etc/propgen Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 3.0.0 to 3.1.1. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v3.0.0...v3.1.1) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * 16.4.7 release * 16.4.8 release * 16.4.11 release * 16.5.1 release * 16.5.2 release * 16.5.3 release * fix: upgrade electron-updater from 4.3.9 to 4.6.5 Snyk has created this PR to upgrade electron-updater from 4.3.9 to 4.6.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/davidjgraph/project/b324f40d-74b4-4545-99b2-af8481e33ed3?utm_source=github&utm_medium=referral&page=upgrade-pr * fix: upgrade electron-log from 4.4.1 to 4.4.4 Snyk has created this PR to upgrade electron-log from 4.4.1 to 4.4.4. See this package in npm: See this project in Snyk: https://app.snyk.io/org/davidjgraph/project/b324f40d-74b4-4545-99b2-af8481e33ed3?utm_source=github&utm_medium=referral&page=upgrade-pr * 16.5.4 release * 16.5.6 release * 16.6.0 release * 16.6.1 release * 16.6.2 release * 16.6.3 release * 16.6.4 release * 16.6.5 release * 16.6.6 release * 16.6.7 release * 16.6.8 release * 17.0.0 release * 17.1.0 release * 17.1.1 release * 17.1.2 release * 17.1.3 release * 17.1.3 release * 17.1.4 release * 17.1.5 release * 17.2.1 release * Fix loading order for javax.cache.CacheManager on App Engine I was running an drawio fork on app engine and Google Drive integration suddenly started failing with IncompatibleClassChangeError errors. Found https://stackoverflow.com/q/46582783 which fixed it. We might not 100% need this. This is mostly a heads up if anyone else runs into similar issues. I'm also not sure if this is easily reproducible on the public App Engine. Following up with GAE to see if this is a bigger issue. * 17.2.1 release * Create codeql-analysis.yml * Create SECURITY.md * Update SECURITY.md * Update codeql-analysis.yml * Update codeql-analysis.yml * 17.2.2 release * Update codeql-analysis.yml * 17.2.3 release * 17.2.4 release * 17.2.5 release * 17.3.0 release * 17.4.0 release * 17.4.1 release * 17.4.2 release * 17.4.3 release * 17.4.3 release * Added java build for codeql * remove git workflow original repo Co-authored-by: Dong Nguyen <ndaidong@gmail.com> Co-authored-by: David Benson [draw.io] <david@jgraph.com> Co-authored-by: Mate Egri <mate.egri78@gmail.com> Co-authored-by: David Benson <david@draw.io> Co-authored-by: Lukasz D <lukasz.dobrogowski@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: David Stephan <stephandavid3@gmail.com> Co-authored-by: Mohamed Mohamedin <ashraf.teleb85@gmail.com>
Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue.
Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue.
Describe the bug
I installed DrawIO latest version with AppImager for Manjaro KDE. KDE menu shows the correct icon of DrawIO.
But I opened it that shows the Xorg icon like default icon in KDE taskbar panel, not drawio's icon.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The drawio's icon should be correct in KDE taskbar and titlebar.
Screenshots

draw.io version (In the Help->About menu of the draw.io editor):
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: