Fix incorrect application icon behavior on Linux #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue.
|
I went to check out the new release and sadly I noticed that the change wasn't included, in fact, it was even reverted in the dev branch... Why is that @davidjgraph ? Was this change causing bugs on other platforms? |
|
Because this isn't the real repo, it's just a mirror. It will come at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jgraph/drawio-desktop#547. I have tested this change only on Linux+KDE and can confirm it works. Obviously some testing on Mac and Windows would be nice to confirm it doesn't break anything. More details in the linked issue.
Before:
drawio-wrong-behavior.mp4
After:
drawio-correct-behavior.mp4