Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinymce html5 containers #35715

Merged
merged 5 commits into from
Nov 13, 2021
Merged

Conversation

brianteeman
Copy link
Contributor

This PR adds the ability to mark your content with aside, article and section which are important landmarks that a content author may wish to use.

To test simply apply this PR and then you will find the new options as shown below.

You can then apply these containers to any blocks of content and verify that it worked either by toggling the editor or by displaying visual characters in tinymce from the toolbar button.

image

image

image

image

This PR adds the ability to mark your content with aside, article and section which are important landmarks that a content author may wish to use.

To test simply apply this PR and then you will find the new options as shown below.

You can then apply these containers to any blocks of content and verify that it worked either by toggling the editor or by displaying visual characters in tinymce from the toolbar button.
@dgrammatiko
Copy link
Contributor

Shouldn't those be in the Block dropdown? Also, capitalise the first letter?

@brianteeman
Copy link
Contributor Author

As they are bigger than blocks I thought it best to place them in their own menu group. Containers can contain blocks.

I chose not to capitalise on purpose (after quite a bit of thought) as they are the name of the tags and not a descriptor of the tag (eg Paragraph for p)

@infograf768
Copy link
Member

The word Containers is not included in TinyMce lang files (see https://github.com/joomla/joomla-cms/blob/ea93a288dab77fe237975f084f586a9241ce53dd/build/media_source/vendor/tinymce/langs/fr.es5.js)

In French it is Conteneurs (plural)
See https://developer.mozilla.org/fr/docs/Web/CSS/Containing_block

I guess it should be translatable and therefore we would need a new string.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 2, 2021
@Quiviro
Copy link

Quiviro commented Oct 22, 2021

I have tested this item ✅ successfully on 05d476d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35715.

1 similar comment
@khu5h1
Copy link
Contributor

khu5h1 commented Nov 9, 2021

I have tested this item ✅ successfully on 05d476d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35715.

@Quy
Copy link
Contributor

Quy commented Nov 12, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35715.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 12, 2021
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@bembelimen bembelimen changed the base branch from 4.0-dev to 4.1-dev November 13, 2021 22:36
@bembelimen bembelimen merged commit b2ff4b4 into joomla:4.1-dev Nov 13, 2021
@joomla-cms-bot joomla-cms-bot added PR-4.1-dev and removed RTC This Pull Request is Ready To Commit labels Nov 13, 2021
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1 milestone Nov 13, 2021
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the tiny_containers branch November 13, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants